[Metrics] Allow getting wandb project name via WANDB_PROJECT
#888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
fegin
reviewed
Feb 25, 2025
Contributor
fegin
left a comment
fegin
left a comment
There was a problem hiding this comment.
I'm okay with the WANDB part. But from torch.utils.tensorboard is the standard PyTorch path not from another repro. So prefer not to use lazy initialization for this.
tianyu-l
reviewed
Feb 26, 2025
| from typing import Any, Dict, Optional | ||
|
|
||
| import torch | ||
| from torch.utils.tensorboard import SummaryWriter |
Contributor
There was a problem hiding this comment.
I have similar question. I'd imagine:
torch.utils.tensorboardis available as long as torch is installed. And it can generate TB logs even iftensorboardlibrary is not installed.tensorboardlibrary can be used to render the TB logs through SSH tunneling.
If that's the case, we can always keeptorch.utils.tensorboardimport.
But I could be wrong.
Contributor
Author
yzhangcs
changed the title
tensorboard dep & allow getting project nam…WANDB_PROJECT
…es from env This commit 1. Move the `tensorboard` imports into class so that it will not raise errors if `tensorboard` not installed. 2. Allow users to obtain `wandb` project name from the env variable `WANDB_PROJECT`, which is defined in their docs.
MaxiBoether
pushed a commit
to eth-easl/torchtitan-mixtera
that referenced
this pull request
Apr 17, 2025
…ch#888) This commit 1. Move the `tensorboard` imports into class so that it will not raise errors if `tensorboard` not installed. 2. Allow users to obtain `wandb` project name from the env variable `WANDB_PROJECT`, which is defined in their docs.
MaxiBoether
pushed a commit
to eth-easl/torchtitan-mixtera
that referenced
this pull request
Apr 17, 2025
…ch#888) This commit 1. Move the `tensorboard` imports into class so that it will not raise errors if `tensorboard` not installed. 2. Allow users to obtain `wandb` project name from the env variable `WANDB_PROJECT`, which is defined in their docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit
tensorboardimports into class so that it will not raise errors iftensorboardnot installed.wandbproject name from the env variableWANDB_PROJECT, which is defined in their docs.