Change variable name from net to model in checkpointing recipe
#2243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
|
@svekars I don't think this should be assigned to torchtext as it is a general tutorial change. |
Contributor
Author
|
@suraj813 kindly pinging you for review 🙂 |
subramen
approved these changes
Mar 28, 2023
Contributor
subramen
left a comment
subramen
left a comment
There was a problem hiding this comment.
No PR is too small
Thanks @kiersten-stokes for improving the quality and correctness of the tutorial!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super small PR that closes #1430
This isn't high priority, but can help with clarity for those learning the concepts. It also prevents an error from being thrown unnecessarily if not all cells of the notebook have been run in the same session. This tutorial has very similar code snippets, and this change makes the code consistent between the two.
Link to tutorial in question.
cc @suraj813 @pytorch/team-text-core