From 03736fd57ea61b6799f6d7eab32b05d7f229ebb9 Mon Sep 17 00:00:00 2001 From: Jirka Date: Sun, 10 Oct 2021 23:52:32 +0200 Subject: [PATCH 1/5] adding PR template --- .github/PULL_REQUEST_TEMPLATE.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000000..56b62fc363a --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,14 @@ +# Before submitting + +- [ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements) +- [ ] Did you make sure to update the docs? +- [ ] Did you write any new necessary tests? + +## What does this PR do? + +Fixes # (issue). + +## PR review + +Anyone in the community is free to review the PR once the tests have passed. +If we didn't discuss your PR in Github issues there's a high chance it will not be merged. From ae6cdbc507cb8e07f786eb928e0e6fc01060e073 Mon Sep 17 00:00:00 2001 From: Jirka Borovec Date: Fri, 19 Nov 2021 22:52:57 +0100 Subject: [PATCH 2/5] update --- .github/PULL_REQUEST_TEMPLATE.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 56b62fc363a..e85ccc40cfc 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,8 +1,6 @@ -# Before submitting +## Before submitting -- [ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements) -- [ ] Did you make sure to update the docs? -- [ ] Did you write any new necessary tests? +Before submitting a PR, please make sure to check our contributing guidelines regarding [code formatting](https://github.com/pytorch/vision/blob/main/CONTRIBUTING.md#code-formatting-and-typing), [tests](https://github.com/pytorch/vision/blob/main/CONTRIBUTING.md#unit-tests), and [documentation](https://github.com/pytorch/vision/blob/main/CONTRIBUTING.md#documentation). ## What does this PR do? From 4ae9501a3dd423403dab6bffc57a7a45f739bbf3 Mon Sep 17 00:00:00 2001 From: Jirka Borovec Date: Mon, 29 Nov 2021 15:38:33 +0100 Subject: [PATCH 3/5] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e85ccc40cfc..6ebc950f629 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,12 +1,8 @@ ## Before submitting Before submitting a PR, please make sure to check our contributing guidelines regarding [code formatting](https://github.com/pytorch/vision/blob/main/CONTRIBUTING.md#code-formatting-and-typing), [tests](https://github.com/pytorch/vision/blob/main/CONTRIBUTING.md#unit-tests), and [documentation](https://github.com/pytorch/vision/blob/main/CONTRIBUTING.md#documentation). +If we didn't discuss your PR in Github issues there's a high chance it will not be merged. ## What does this PR do? -Fixes # (issue). - -## PR review - -Anyone in the community is free to review the PR once the tests have passed. -If we didn't discuss your PR in Github issues there's a high chance it will not be merged. + From 3d85a9a59442b560e1499a5b4403cf0f671e769a Mon Sep 17 00:00:00 2001 From: Jirka Borovec Date: Mon, 29 Nov 2021 15:39:25 +0100 Subject: [PATCH 4/5] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 6ebc950f629..1aedc898c96 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,7 +1,9 @@ ## Before submitting + ## What does this PR do? From ba753eb0f7052a12c16134beb009d83ef11c0e0b Mon Sep 17 00:00:00 2001 From: Jirka Borovec Date: Mon, 29 Nov 2021 18:35:32 +0100 Subject: [PATCH 5/5] Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Nicolas Hug --- .github/PULL_REQUEST_TEMPLATE.md | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1aedc898c96..f267cc7da50 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,10 +1 @@ -## Before submitting - - - -## What does this PR do? - - +