From f453bea79f6d0456163adbd6245a7c0bcdb44fef Mon Sep 17 00:00:00 2001 From: Vasilis Vryniotis Date: Fri, 29 Oct 2021 10:36:38 +0100 Subject: [PATCH 1/4] Show git diff after lint run --- .circleci/config.yml | 1 + .circleci/config.yml.in | 1 + 2 files changed, 2 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index a17410b9a6f..3df5716383f 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -187,6 +187,7 @@ jobs: pip install --user --progress-bar off pre-commit pre-commit install-hooks - run: pre-commit run --all-files + - run: git diff python_type_check: docker: diff --git a/.circleci/config.yml.in b/.circleci/config.yml.in index 4b0bc8d7e1d..bbd1937e945 100644 --- a/.circleci/config.yml.in +++ b/.circleci/config.yml.in @@ -187,6 +187,7 @@ jobs: pip install --user --progress-bar off pre-commit pre-commit install-hooks - run: pre-commit run --all-files + - run: git diff python_type_check: docker: From 7a966d5141796204192595e89abb9afb5516227d Mon Sep 17 00:00:00 2001 From: Vasilis Vryniotis Date: Fri, 29 Oct 2021 10:38:06 +0100 Subject: [PATCH 2/4] break both flake8 and ufmt --- torchvision/models/alexnet.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/torchvision/models/alexnet.py b/torchvision/models/alexnet.py index bb812febdc4..a182fd181f6 100644 --- a/torchvision/models/alexnet.py +++ b/torchvision/models/alexnet.py @@ -1,4 +1,4 @@ -from typing import Any +from typing import Any, Optional import torch import torch.nn as nn @@ -7,7 +7,7 @@ from ..utils import _log_api_usage_once -__all__ = ["AlexNet", "alexnet"] +__all__ = ['AlexNet', "alexnet"] model_urls = { From ffaf39c910acb5287ebece547b85f9f11f058c15 Mon Sep 17 00:00:00 2001 From: Vasilis Vryniotis Date: Fri, 29 Oct 2021 10:43:16 +0100 Subject: [PATCH 3/4] Make it run on fail --- .circleci/config.yml | 5 ++++- .circleci/config.yml.in | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3df5716383f..ce76f0b722c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -187,7 +187,10 @@ jobs: pip install --user --progress-bar off pre-commit pre-commit install-hooks - run: pre-commit run --all-files - - run: git diff + - run: + name: Modifications + when: on_fail + command: git diff python_type_check: docker: diff --git a/.circleci/config.yml.in b/.circleci/config.yml.in index bbd1937e945..84879d1eb22 100644 --- a/.circleci/config.yml.in +++ b/.circleci/config.yml.in @@ -187,7 +187,10 @@ jobs: pip install --user --progress-bar off pre-commit pre-commit install-hooks - run: pre-commit run --all-files - - run: git diff + - run: + name: Modifications + when: on_fail + command: git diff python_type_check: docker: From 7a405ca7343135d9a23508f1749a7eefb698a044 Mon Sep 17 00:00:00 2001 From: Vasilis Vryniotis Date: Fri, 29 Oct 2021 10:46:12 +0100 Subject: [PATCH 4/4] Undo breaks and fix job message. --- .circleci/config.yml | 2 +- .circleci/config.yml.in | 2 +- torchvision/models/alexnet.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index ce76f0b722c..6dedce6a076 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -188,7 +188,7 @@ jobs: pre-commit install-hooks - run: pre-commit run --all-files - run: - name: Modifications + name: Required lint modifications when: on_fail command: git diff diff --git a/.circleci/config.yml.in b/.circleci/config.yml.in index 84879d1eb22..b96132790c4 100644 --- a/.circleci/config.yml.in +++ b/.circleci/config.yml.in @@ -188,7 +188,7 @@ jobs: pre-commit install-hooks - run: pre-commit run --all-files - run: - name: Modifications + name: Required lint modifications when: on_fail command: git diff diff --git a/torchvision/models/alexnet.py b/torchvision/models/alexnet.py index a182fd181f6..bb812febdc4 100644 --- a/torchvision/models/alexnet.py +++ b/torchvision/models/alexnet.py @@ -1,4 +1,4 @@ -from typing import Any, Optional +from typing import Any import torch import torch.nn as nn @@ -7,7 +7,7 @@ from ..utils import _log_api_usage_once -__all__ = ['AlexNet', "alexnet"] +__all__ = ["AlexNet", "alexnet"] model_urls = {