From 7a42f33deac0d5df318486988defd4723e010f73 Mon Sep 17 00:00:00 2001
From: Joao Gomes <jdsgomes@fb.com>
Date: Tue, 22 Feb 2022 21:00:14 +0000
Subject: [PATCH 1/3] Make small improvements to the release notes scripts

Add release tags as parameters, exclude prototype stuff from release notes and
automate contributors list
---
 scripts/release_notes/classify_prs.py | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/scripts/release_notes/classify_prs.py b/scripts/release_notes/classify_prs.py
index 9b7870a3c51..5cbde5fac34 100644
--- a/scripts/release_notes/classify_prs.py
+++ b/scripts/release_notes/classify_prs.py
@@ -1,13 +1,17 @@
 # In[1]:
 
-
+# imports and set configuration
 import pandas as pd
 
+exclude_prototype = True
+data_filename = "10.0_to_11.0-rc2.json"
+previous_release = "v10.0"
+current_release = "v11.0-rc2"
 
 # In[2]:
 
 
-df = pd.read_json("10.0_to_11.0-rc2.json").T
+df = pd.read_json(data_filename).T
 df.tail()
 
 
@@ -76,6 +80,8 @@
 def format_prs(mod_df):
     out = []
     for idx, row in mod_df.iterrows():
+        if exclude_prototype and row["prototype"]:
+            continue
         modules = idx
         # Put "documentation" and "tests" first for sorting to be dece
         for last_module in ("documentation", "tests"):
@@ -119,3 +125,10 @@ def format_prs(mod_df):
 # Missing PRs are these ones... classify them manually
 missing_prs = pd.concat([mod_df, included_prs]).drop_duplicates(subset="pr_number", keep=False)
 print(format_prs(missing_prs))
+
+# In[12]:
+
+# Generate list of authors
+command_to_run = f"{{ git shortlog -s {previous_release}..{current_release} | cut -f2- & git log -s {previous_release}..{current_release} | grep Co-authored | cut -f2- -d: | cut -f1 -d\< | sed 's/^ *//;s/ *$//' ; }} | sort --ignore-case | uniq | tr '\n' ';' | sed 's/;/, /g;s/, $//' | fold -s"
+print(command_to_run)
+# %%

From 3af4189d5e6130ee4e904087e7b6deca14e7329b Mon Sep 17 00:00:00 2001
From: Joao Gomes <jdsgomes@fb.com>
Date: Wed, 23 Feb 2022 12:40:42 +0000
Subject: [PATCH 2/3] Add code to run the command for contributors list
 generation

---
 scripts/release_notes/classify_prs.py | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/scripts/release_notes/classify_prs.py b/scripts/release_notes/classify_prs.py
index 5cbde5fac34..49a19130e91 100644
--- a/scripts/release_notes/classify_prs.py
+++ b/scripts/release_notes/classify_prs.py
@@ -2,6 +2,7 @@
 
 # imports and set configuration
 import pandas as pd
+from retrieve_prs_data import run
 
 exclude_prototype = True
 data_filename = "10.0_to_11.0-rc2.json"
@@ -128,7 +129,11 @@ def format_prs(mod_df):
 
 # In[12]:
 
-# Generate list of authors
-command_to_run = f"{{ git shortlog -s {previous_release}..{current_release} | cut -f2- & git log -s {previous_release}..{current_release} | grep Co-authored | cut -f2- -d: | cut -f1 -d\< | sed 's/^ *//;s/ *$//' ; }} | sort --ignore-case | uniq | tr '\n' ';' | sed 's/;/, /g;s/, $//' | fold -s"
-print(command_to_run)
-# %%
+# Generate list of contributors
+print()
+print(f"## Contributors")
+
+command_to_run = f"{{ git shortlog -s {previous_release}..{current_release} | cut -f2- & git log -s {previous_release}..{current_release} | grep Co-authored | cut -f2- -d: | cut -f1 -d\< | sed 's/^ *//;s/ *$//' ; }} | sort --ignore-case | uniq | tr '\\n' ';' | sed 's/;/, /g;s/, $//' | fold -s"
+rc, output, err = run(command_to_run)
+print(output)
+

From 87303a54d2421a628ecc8419d31410a85a1247b2 Mon Sep 17 00:00:00 2001
From: Joao Gomes <jdsgomes@fb.com>
Date: Wed, 23 Feb 2022 13:07:37 +0000
Subject: [PATCH 3/3] fix lint errors

---
 scripts/release_notes/classify_prs.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/scripts/release_notes/classify_prs.py b/scripts/release_notes/classify_prs.py
index 49a19130e91..de55c299381 100644
--- a/scripts/release_notes/classify_prs.py
+++ b/scripts/release_notes/classify_prs.py
@@ -131,9 +131,8 @@ def format_prs(mod_df):
 
 # Generate list of contributors
 print()
-print(f"## Contributors")
+print("## Contributors")
 
-command_to_run = f"{{ git shortlog -s {previous_release}..{current_release} | cut -f2- & git log -s {previous_release}..{current_release} | grep Co-authored | cut -f2- -d: | cut -f1 -d\< | sed 's/^ *//;s/ *$//' ; }} | sort --ignore-case | uniq | tr '\\n' ';' | sed 's/;/, /g;s/, $//' | fold -s"
+command_to_run = f"{{ git shortlog -s {previous_release}..{current_release} | cut -f2- & git log -s {previous_release}..{current_release} | grep Co-authored | cut -f2- -d: | cut -f1 -d\\< | sed 's/^ *//;s/ *$//' ; }} | sort --ignore-case | uniq | tr '\\n' ';' | sed 's/;/, /g;s/, $//' | fold -s"
 rc, output, err = run(command_to_run)
 print(output)
-