diff --git a/torch_xla/csrc/ops/dynamic_ir.cpp b/torch_xla/csrc/ops/dynamic_ir.cpp index e3547928428..af61710d879 100644 --- a/torch_xla/csrc/ops/dynamic_ir.cpp +++ b/torch_xla/csrc/ops/dynamic_ir.cpp @@ -26,7 +26,7 @@ int64_t SizeNode::getStaticValue() const { return operand(0).node->shape(0).size(dim_); } -bool SizeNode::isDynamic() const { +bool SizeNode::isSymbolic() const { auto symbolic_vec = operand(0).node->shape(0).is_symbolic(); if (!symbolic_vec.has_value()) { return true; @@ -47,8 +47,8 @@ int64_t SizeAdd::getStaticValue() const { ->getStaticValue(); } -bool SizeAdd::isDynamic() const { - return DimCast(operand(0))->isDynamic() || DimCast(operand(1))->isDynamic(); +bool SizeAdd::isSymbolic() const { + return DimCast(operand(0))->isSymbolic() || DimCast(operand(1))->isSymbolic(); } std::string SizeAdd::ToString() const { return "SizeAdd"; } @@ -72,8 +72,8 @@ int64_t SizeMul::getStaticValue() const { ->getStaticValue(); } -bool SizeMul::isDynamic() const { - return DimCast(operand(0))->isDynamic() || DimCast(operand(1))->isDynamic(); +bool SizeMul::isSymbolic() const { + return DimCast(operand(0))->isSymbolic() || DimCast(operand(1))->isSymbolic(); } std::string SizeMul::ToString() const { return "SizeMul"; } @@ -100,8 +100,8 @@ int64_t SizeDiv::getStaticValue() const { ->getStaticValue(); } -bool SizeDiv::isDynamic() const { - return DimCast(operand(0))->isDynamic() || DimCast(operand(1))->isDynamic(); +bool SizeDiv::isSymbolic() const { + return DimCast(operand(0))->isSymbolic() || DimCast(operand(1))->isSymbolic(); } std::string SizeDiv::ToString() const { return "SizeDiv"; } diff --git a/torch_xla/csrc/ops/dynamic_ir.h b/torch_xla/csrc/ops/dynamic_ir.h index 2e82f851257..1f5cef36058 100644 --- a/torch_xla/csrc/ops/dynamic_ir.h +++ b/torch_xla/csrc/ops/dynamic_ir.h @@ -39,7 +39,7 @@ class SizeNode : public XlaNode, public torch::lazy::DimensionNode { public: SizeNode(torch::lazy::Value input, size_t dim); int64_t getStaticValue() const override; - bool isDynamic() const override; + bool isSymbolic() const override; std::string ToString() const override; virtual XlaOpVector Lower(LoweringContext* loctx) const override; @@ -51,7 +51,7 @@ class SizeAdd : public XlaNode, public torch::lazy::DimensionNode { public: SizeAdd(torch::lazy::Value a, torch::lazy::Value b); int64_t getStaticValue() const override; - bool isDynamic() const override; + bool isSymbolic() const override; std::string ToString() const override; virtual XlaOpVector Lower(LoweringContext* loctx) const override; }; @@ -60,7 +60,7 @@ class SizeMul : public XlaNode, public torch::lazy::DimensionNode { public: SizeMul(torch::lazy::Value a, torch::lazy::Value b); int64_t getStaticValue() const override; - bool isDynamic() const override; + bool isSymbolic() const override; std::string ToString() const override; virtual XlaOpVector Lower(LoweringContext* loctx) const override; }; @@ -69,7 +69,7 @@ class SizeDiv : public XlaNode, public torch::lazy::DimensionNode { public: SizeDiv(torch::lazy::Value a, torch::lazy::Value b); int64_t getStaticValue() const override; - bool isDynamic() const override; + bool isSymbolic() const override; std::string ToString() const override; virtual XlaOpVector Lower(LoweringContext* loctx) const override; }; diff --git a/torch_xla/csrc/torch_util.cpp b/torch_xla/csrc/torch_util.cpp index 330e6cbcdcd..4c71166e34d 100644 --- a/torch_xla/csrc/torch_util.cpp +++ b/torch_xla/csrc/torch_util.cpp @@ -19,7 +19,7 @@ void SymIntElements::SetSymIntNodeElements(c10::SymInt& size) { ->getStaticValue()); dynamic_dims_.push_back( std::dynamic_pointer_cast(size_node) - ->isDynamic()); + ->isSymbolic()); } else { auto size_node = torch::lazy::MakeNode(std::move( XlaHelpers::ScalarLiteral(size.expect_int(), xla::PrimitiveType::S32)));