Skip to content

Add the dynamic shape unit test the CI. #4180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vanbasten23 merged 4 commits into from
Nov 15, 2022
Merged

Add the dynamic shape unit test the CI. #4180

vanbasten23 merged 4 commits into from
Nov 15, 2022

Conversation

@vanbasten23
Copy link
Collaborator

@vanbasten23 vanbasten23 commented Nov 9, 2022

@vanbasten23 vanbasten23 mentioned this pull request Nov 9, 2022
Closed
@JackCaoG JackCaoG requested a review from Krovatkin November 9, 2022 22:22
@vanbasten23 vanbasten23 mentioned this pull request Nov 9, 2022
Closed
ezyang
ezyang reviewed Nov 11, 2022
View reviewed changes
ezyang
ezyang reviewed Nov 11, 2022
View reviewed changes
test/run_tests.sh
run_dynamic python3 "$CDIR/../../test/nn/test_embedding.py" "$@" -v TestEmbeddingNNDeviceTypeXLA
run_dynamic python3 "$CDIR/../../test/test_type_promotion.py" "$@" -v TestTypePromotionXLA
run_dynamic python3 "$CDIR/test_operations.py" "$@" --verbosity=$VERBOSITY
run_dynamic python3 "$CDIR/test_dynamic_shapes.py" "$@"
Copy link
Collaborator

@ezyang ezyang Nov 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to turn on experimental shapes

Copy link
Collaborator

@JackCaoG JackCaoG Nov 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run_dynamic will enable those flags.

xla/test/run_tests.sh

Lines 64 to 71 in 515d53e

function run_dynamic {
if [[ "$TPUVM_MODE" == "1" ]]; then
run_test "$@"
else
echo "Running in DynamicShape mode: $@"
XLA_EXPERIMENTAL="nonzero:masked_select:masked_scatter" run_test "$@"
fi
}

@vanbasten23 vanbasten23 changed the title Fix the dynamic shape test and add it to the CI. Add the dynamic shape unit test the CI. Nov 14, 2022
@vanbasten23 vanbasten23 requested a review from JackCaoG November 14, 2022 18:35
@JackCaoG
Copy link
Collaborator

JackCaoG commented Nov 14, 2022

Has the issue been fixed?

@vanbasten23
Copy link
Collaborator Author

vanbasten23 commented Nov 14, 2022

Yes, the test start passing.

JackCaoG
JackCaoG approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to merge once CI is green.

@vanbasten23 vanbasten23 merged commit a843d8b into master Nov 15, 2022
@vanbasten23 vanbasten23 mentioned this pull request Nov 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang left review comments

@JackCaoG JackCaoG JackCaoG approved these changes

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix dynamic shape test (xla/test/test_dynamic_shapes.py) and add it to pytorch/xla's CI.

4 participants

@vanbasten23 @JackCaoG @ezyang