From eae135655fd89f0f6cf58c08ee32273398fff8ea Mon Sep 17 00:00:00 2001 From: Xiongfei Wei Date: Thu, 17 Nov 2022 23:28:33 +0000 Subject: [PATCH 1/2] Improve XLASynNodeImpl str() format --- test/cpp/test_symint.cpp | 2 +- torch_xla/csrc/tensor.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/cpp/test_symint.cpp b/test/cpp/test_symint.cpp index 749c4d933648..af5b242800da 100644 --- a/test/cpp/test_symint.cpp +++ b/test/cpp/test_symint.cpp @@ -214,7 +214,7 @@ TEST(SymintTest, TestXLASymNodeImplStr) { torch::lazy::NodePtr size_node = torch::lazy::MakeNode(expand_value, 0); c10::SymNode symint_node = c10::make_intrusive(size_node); - ASSERT_EQ(symint_node.get()->str(), "Static bound: 2"); + ASSERT_EQ(symint_node.get()->str(), "<=2"); } } // namespace cpp_test diff --git a/torch_xla/csrc/tensor.cpp b/torch_xla/csrc/tensor.cpp index 1bf0100fa18c..e141f0d8d30e 100644 --- a/torch_xla/csrc/tensor.cpp +++ b/torch_xla/csrc/tensor.cpp @@ -1990,7 +1990,7 @@ c10::SymNode XLASymNodeImpl::floordiv(const c10::SymNode& other) { } std::string XLASymNodeImpl::str() { - return "Static bound: " + + return "<=" + std::to_string(DimCast(node().get())->getStaticValue()); } From e128b88cb515e18f60b6ec8f6aa351dea6c9f7ed Mon Sep 17 00:00:00 2001 From: Xiongfei Wei Date: Thu, 17 Nov 2022 23:54:08 +0000 Subject: [PATCH 2/2] fix the linter --- torch_xla/csrc/tensor.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/torch_xla/csrc/tensor.cpp b/torch_xla/csrc/tensor.cpp index e141f0d8d30e..ec795f9b636b 100644 --- a/torch_xla/csrc/tensor.cpp +++ b/torch_xla/csrc/tensor.cpp @@ -1990,8 +1990,7 @@ c10::SymNode XLASymNodeImpl::floordiv(const c10::SymNode& other) { } std::string XLASymNodeImpl::str() { - return "<=" + - std::to_string(DimCast(node().get())->getStaticValue()); + return "<=" + std::to_string(DimCast(node().get())->getStaticValue()); } torch::lazy::hash_t XLATensor::GetGraphHash(