Add step-mark operation, and split sync-tensors into a separate opera…#627
Merged
Conversation
asuhan
reviewed
Apr 21, 2019
asuhan
left a comment
asuhan
left a comment
Contributor
There was a problem hiding this comment.
- Is
AddSyncedHashmeant to be used by the speculative sync? - What is the API to specify metadata going to be? I assume we want to expose it all the way to Python somehow.
Collaborator
Author
Yeah. This is base infra. Missing bits are:
The metadata is because we know about IR nodes, but we have no idea about which XLATensor::Data hosts them. |
dlibenzi
force-pushed
the
mark_the_step
branch
2 times, most recently
from
12b5679 to
4cf04d2
Compare
…tion. Added ability to associate user defined metadata to IR nodes, to be able to link back IR nodes to the hosting XLATensor::Data core data structure. Reorganized the XLA tensors arena in a more general device context arena, to be able to host other information on top of live tensors data.
asuhan
approved these changes
Apr 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion.
Added ability to associate user defined metadata to IR nodes, to be able to link back IR nodes to the hosting XLATensor::Data core data structure.
Reorganized the XLA tensors arena in a more general device context arena, to be able to host other information on top of live tensors data.