Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling in SCPMover #13

Merged
merged 2 commits into from Jan 21, 2019

Conversation

@TAlonglong
Copy link
Collaborator

commented Aug 3, 2018

If something wrong happens with the scp.put the ssh and scp object is left open. They need to be closed.

except Exception as e:
LOGGER.error("Something went wrong with scp: " + str(e))
finally:
scp.close()

This comment has been minimized.

Copy link
@mraspaud

mraspaud Aug 6, 2018

Member

if the SCPClient call fails, the scp object isn't created, and the subsequent call to close will crash...

@mraspaud mraspaud merged commit d5de9ee into pytroll:master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.