Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added view which reuses the session detail template and adds correct linkage #193

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mcurlej
Copy link
Collaborator

commented May 25, 2019

We needed a way to display correct linkage, on session detail, when someone
clicked on an item from the schedule. Also fixed several remainers of the
field date which was removed in the commit 852b08e.

Ticket-ID: #128

Signed-off-by: Martin Curlej mcurlej@redhat.com

@mcurlej

This comment has been minimized.

Copy link
Collaborator Author

commented May 25, 2019

@frenzymadness @starenka @benabraham prosim o review?

Inac zostali tam nejake 'date' fieldy zo Slot modelu ked sa to menilo v predchadzajucom commite na start a end. Rozbilo to web, zmenil som to na start field. Mozte pozriet ci je to spravne? lebo nie som si 100% ako to ovplyvni zvysok webu. Dik.

@benabraham benabraham self-requested a review May 25, 2019

@frenzymadness

This comment has been minimized.

Copy link
Member

commented May 26, 2019

Testuju to a vypadá to dobře. Našel jsem zatím jen dva problémy:

  • Když u prvního slotu v clubu v páte ráno kliknu na previous, dostanu poslední talk v clubu v sobotu večer
  • Nefungují odkazy na keynoty a to ani přímo z programu ani při klikání na previous/next

Nasadím to na betu, ať se na to mohou podívat i ostatní.

@frenzymadness

This comment has been minimized.

Copy link
Member

commented May 26, 2019

deployed to beta

@mcurlej mcurlej force-pushed the mcurlej:issue_128 branch from 9666ecd to 8d83465 Jun 1, 2019

@mcurlej

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 1, 2019

@frenzymadness takze fixnute, ak je talk prvy v programe nema previous button, ak je posledny v posledny den nema next button. Parallel track button sa nezobrazuje pri keynote.

Added view which reuses the session detail template and adds correct …
…linkage

We needed a way to display correct linkage, on session detail, when someone
clicked on an item from the schedule. Also fixed several remainers of the
field date which was removed in the commit 852b08e.

Ticket-ID: #128

Signed-off-by: Martin Curlej <mcurlej@redhat.com>

@mcurlej mcurlej force-pushed the mcurlej:issue_128 branch from 8d83465 to 54997b4 Jun 6, 2019

@mcurlej

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 6, 2019

@benabraham @frenzymadness Ahojte, je to rebasnute, prosim pozrite sa na to a mergnite to. Do Nedele som na chate a nebudem mat pristup k pc.

@benabraham

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Podívám.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.