New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make URLs properly hiearchical #168

Open
Sanqui opened this Issue Jul 19, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@Sanqui
Member

Sanqui commented Jul 19, 2017

Currently URLs for lessons expose the file directories used internally in the filesystem, rather than matching the sessions in the breadcrumbs. Observe:

http://naucse.python.cz/2017/pyladies-brno-jaro-po/
http://naucse.python.cz/2017/pyladies-brno-jaro-po/sessions/install/ (issue #164)
http://naucse.python.cz/2017/pyladies-brno-jaro-po/beginners/cmdline/
http://naucse.python.cz/2017/pyladies-brno-jaro-po/git/install/

The last two URLs are a part of the "install" session. In order to match the breadcrumbs, they should instead say something like:

http://naucse.python.cz/2017/pyladies-brno-jaro-po/install/cmdline/
http://naucse.python.cz/2017/pyladies-brno-jaro-po/install/git/

Additionally, this issue enables you to "cheat" and access pages that are not truly a part of the course, like http://naucse.python.cz/2017/pyladies-brno-jaro-po/intro/flask/. This only works with a real webserver and not Elsa, however, since these pages are not linked anywhere.

Blocked by #163, because any URL scheme changes require redirects.

@Sanqui Sanqui self-assigned this Jul 19, 2017

@encukou

This comment has been minimized.

Member

encukou commented Jul 20, 2017

The "phantom pages" are intentional: for example /2017/pyknihovny-brno/fast-track/install/ links to /2017/pyknihovny-brno/beginners/install/. The latter is not included in the table of contents, but I think of it a part of the course, rather than an external link.

The courses should ultimately be self-contained, in that content changes in master should not affect a currently running course – we don't want to change materials without the teacher's knowledge.

@Sanqui

This comment has been minimized.

Member

Sanqui commented Jul 20, 2017

Phantom pages as they are implemented now would work for any lesson, whether linked somewhere or not. The fact that they don't live is a side effect of the freezing process. However, eventually it will be necessary to define the pages that lay outside of the course plan but are linked in advance. (I'd rather not auto-detect links.)

This is low priority.

@encukou encukou added the code label Aug 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment