New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchors missing #217

Open
hroncok opened this Issue Oct 4, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@hroncok
Member

hroncok commented Oct 4, 2017

h2s don't have anchors to link to (such as on a session/lecture page as for example http://naucse.python.cz/2017/pyladies-praha-podzim-ntk/beginners/str/)

@hroncok hroncok self-assigned this Oct 4, 2017

@encukou

This comment has been minimized.

Member

encukou commented Oct 6, 2017

Since anchor names are part of the URL (which is our "API"), we shouldn't generate anchor names from the heading text (so we can reword headings later).

Also, a rendered header should include a link to itself, so the URL is discoverable.

Maybe there's already a MD extension to do this?

@hroncok

This comment has been minimized.

Member

hroncok commented Oct 9, 2017

So the id attribute of the heading should be hardcoded, not slugged?

@encukou

This comment has been minimized.

Member

encukou commented Oct 10, 2017

I think that's the best way to solve this, yes.

When someone rewords/removes a section heading, I'd expect that neither that person nor the reviewer will even think about the effect on URL stability. And I'd rather provide no section links at all than ones that can change arbitrarily.

@hroncok

This comment has been minimized.

Member

hroncok commented Oct 10, 2017

Got it. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment