New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored DirProperty to enable subclassing #347

Merged
merged 1 commit into from Mar 17, 2018

Conversation

Projects
None yet
3 participants
@mikicz
Copy link
Member

mikicz commented Mar 16, 2018

I need to subclass the property in my thesis implementation, so I made this modification in a separate branch to make the diff bit nicer when the big PR comes.

@hroncok hroncok requested a review from encukou Mar 16, 2018

@encukou encukou merged commit bb85e3f into pyvec:master Mar 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mikicz mikicz deleted the mikicz:dir-property-refactor branch Mar 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment