Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework lesson on list, tuple, range; add enumerate & zip #639

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

encukou
Copy link
Member

@encukou encukou commented Jul 27, 2020

Here's one more rework of existing lessons.

  • A graphical overview of list mutation methods
  • More thorough explanation of mutability
  • Lesson on Nested lists, and enumerate & zip are split out
    • The enumerate & zip lesson has some more focus on how iterables behave in general
    • The enumerate & zip lesson includes unpacking in for
  • New lesson on range, which should set the scene for enumerate & zip

Please review the changes as a whole, don't look at individual commits. But, to make cherry-picking easier, don't squash when merging.

@encukou encukou marked this pull request as draft Jul 27, 2020
@encukou encukou marked this pull request as ready for review Jul 27, 2020
Copy link
Contributor

@adelpopelkova adelpopelkova left a comment

The changes look good. I really like the new parts, especially the ones with zip and enumerate. I left a few comments and suggestions, mostly fixing typos.

lessons/beginners/zip-enumerate/index.md Outdated Show resolved Hide resolved
lessons/beginners/zip-enumerate/index.md Outdated Show resolved Hide resolved
lessons/beginners/range/index.md Outdated Show resolved Hide resolved
lessons/beginners/nested-list/index.md Outdated Show resolved Hide resolved
lessons/beginners/tuple/index.md Outdated Show resolved Hide resolved
lessons/beginners/list/index.md Outdated Show resolved Hide resolved
lessons/beginners/list/index.md Outdated Show resolved Hide resolved
lessons/beginners/list/index.md Outdated Show resolved Hide resolved
lessons/beginners/list/index.md Outdated Show resolved Hide resolved
lessons/beginners/list/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Glutexo Glutexo left a comment

Request changes jen kvůli dvěma chybkám. Jinak poznámky pouze informativní. Jenom k seznamům.

lessons/beginners/list/index.md Outdated Show resolved Hide resolved
lessons/beginners/list/index.md Outdated Show resolved Hide resolved
lessons/beginners/list/index.md Outdated Show resolved Hide resolved
lessons/beginners/list/index.md Outdated Show resolved Hide resolved
lessons/beginners/list/index.md Outdated Show resolved Hide resolved
lessons/beginners/list/index.md Outdated Show resolved Hide resolved
lessons/beginners/list/index.md Outdated Show resolved Hide resolved
lessons/beginners/list/index.md Show resolved Hide resolved
lessons/beginners/list/index.md Outdated Show resolved Hide resolved
lessons/beginners/list/index.md Show resolved Hide resolved
Co-authored-by: Glutexo <driezasson@me.com>
Co-authored-by: adelpopelkova <59389471+adelpopelkova@users.noreply.github.com>
lessons/beginners/list/index.md Outdated Show resolved Hide resolved
lessons/beginners/list/index.md Outdated Show resolved Hide resolved
encukou and others added 6 commits Aug 10, 2020
Co-authored-by: adelpopelkova <59389471+adelpopelkova@users.noreply.github.com>
Optimization is left as an exercise, but also given a bit later.
> „vrátí“ [vyzní] víc jako „vrátí zpátky do seznamu“ než jako „return“

 Co-authored-by: Glutexo <driezasson@me.com>
encukou added a commit to encukou/naucse.python.cz that referenced this pull request Nov 16, 2020
…e & zip)

This includes some additions already in this branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants