Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review validation of src/href #9

encukou opened this issue Aug 28, 2018 · 0 comments

Review validation of src/href #9

encukou opened this issue Aug 28, 2018 · 0 comments


Copy link

encukou commented Aug 28, 2018

Currently the code rejects links that .startswith("javascript:"). This is blacklisting. Blacklisting is bad.
We'll want to whitelist only things like http://, https://, and data:// with specific mimetypes.

Consider: <a href="javaScript:alert('gotcha')">click here</a>.

@encukou encukou transferred this issue from pyvec/ Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

No branches or pull requests

1 participant