Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolbars to Qt plotter #351

Merged
merged 7 commits into from Oct 13, 2019
Merged

Add toolbars to Qt plotter #351

merged 7 commits into from Oct 13, 2019

Conversation

banesullivan
Copy link
Member

What other options should be in a toolbar?

Perhaps we should overhaul the saved camera locations to be managed in a toolbar?

2019-08-03 16 34 00

@banesullivan
Copy link
Member Author

I've generalized this so that we could add various toolbars

@banesullivan banesullivan changed the title Add view angles toolbar to Qt plotter Add toolbars to Qt plotter Aug 3, 2019
@banesullivan banesullivan self-assigned this Aug 3, 2019
@codecov-io
Copy link

Codecov Report

Merging #351 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   84.62%   84.65%   +0.02%     
==========================================
  Files          30       30              
  Lines        7169     7181      +12     
==========================================
+ Hits         6067     6079      +12     
  Misses       1102     1102

@banesullivan banesullivan added the enhancement Changes that enhance the library label Aug 4, 2019
@akaszynski
Copy link
Member

Saved locations might look great as a table within a panel, but that’s quite an overhaul. I like the toolbar.

@banesullivan
Copy link
Member Author

It was pretty easy to reimplement the saved cameras into a toolbar:

2019-08-04 15 20 40

@banesullivan
Copy link
Member Author

banesullivan commented Aug 4, 2019

I'm getting some weird warning when I try to move the toolbar:

qt.qpa.cocoa.window: <QNSPanel: 0x7ff69c8ecce0> has active key-value observers (KVO)! 
These will stop working now that the window is recreated, and will result in exceptions when the
observers are removed. Break in QCocoaWindow::recreateWindowIfNeeded to debug.

Also the window moves when relocate one of the toolbars

@banesullivan banesullivan marked this pull request as ready for review October 9, 2019 05:29
@banesullivan
Copy link
Member Author

@GuillaumeFavelier, you leverage the BackgrounPlotter a lot, are there any other features you'd like to see as a toolbar?

Also, if you have the time, a code review would be much appreciated since you have more experience with Qt than I.

@banesullivan banesullivan merged commit ca13014 into master Oct 13, 2019
@banesullivan banesullivan deleted the qt-toolbar branch October 13, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants