Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for RasterGridPlot #1012

Merged
merged 1 commit into from Dec 11, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Dec 10, 2016

As described in #976 RasterGridPlot currently fails because it has no streams attribute. This is because it's a very atypical plot type that does not currently support streams, making streams and comms work with it will be some effort. Once this has been merged we should open an issue to add that support.

Philipp Rudiger Philipp Rudiger

@philippjfr philippjfr force-pushed the raster_grid_fix branch from 46b8324 to 5140a3f Dec 10, 2016

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Dec 10, 2016

Not sure why the tests didn't fail here but the broken plot in Exploring_Data seems to be working now.

Edit: The tests don't display widgets which is what triggered this issue. So it makes sense.

@philippjfr philippjfr requested a review from jlstevens Dec 10, 2016

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Dec 11, 2016

@jlstevens Ready to merge, just a very tiny stub for the time being.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Dec 11, 2016

Once this has been merged we should open an issue to add that support.

Please do!

@jlstevens jlstevens merged commit 4fc1186 into master Dec 11, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 75.997%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the raster_grid_fix branch Jan 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.