Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
New diagonal_operation-Parameter for the gridmatrix operation #1027
Instead of being restricted to a plot type along the diagonal of a gridmatrix-operation, this pull request also allows the specification of an operation. The main reasoning for this is that it is now possible to change parameters like the number of bins in a diagonal histogram:
data = pd.DataFrame(np.random.normal(size=(250, 3)), columns=['a', 'b', 'c']) hvset = hv.Dataset(data.reset_index(), kdims=['index']) hv.operation.gridmatrix( hvset, diagonal_operation=hv.operation.histogram.instance(num_bins=30, adjoin=False) )
I think in its current state, this PR is not ready however, since there are a few open questions:
When the semantics are decided, I can also add a few tests. I will probably need a few hints however on how to test this.
You're right, it appears operations are not currently tested at all! I'd create a new file called