Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh TextPlot uses Text parameter settings #1157

Merged
merged 1 commit into from Feb 27, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Feb 27, 2017

Previously bokeh ignored the alignment parameters on the Text Element.

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Feb 27, 2017

Will have to rebuild test data, small change to Bokeh_Elements unsurprisingly.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Feb 27, 2017

Looks like a good change. Happy to merge once the tests pass.

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Feb 27, 2017

Ready to merge, PR build passed.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Feb 27, 2017

Great! Merging now.

@jlstevens jlstevens merged commit e09d665 into master Feb 27, 2017

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 78.207%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the text_alignment branch Feb 27, 2017

@philippjfr philippjfr added this to the v1.7.0 milestone Feb 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.