Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in documentation #1273

Merged
merged 10 commits into from Apr 12, 2017

Conversation

Projects
None yet
2 participants
@jlstevens
Copy link
Contributor

jlstevens commented Apr 11, 2017

This PR addresses issues #198 and #1251 regarding broken links.

@jlstevens

This comment has been minimized.

Copy link
Contributor Author

jlstevens commented Apr 11, 2017

I'll run a website build and then run a link checker on dev.holoviews.org.

@philippjfr

This comment has been minimized.

Copy link
Contributor

philippjfr commented Apr 11, 2017

Would be good if you could update this paragraph in the index.rst with the most recent versions:

HoloViews works with Python 2.7, 3.3, and 3.4 <https://travis-ci.org/ioam/holoviews>_.

HoloViews is pure Python, but it also provides optional extensions
enabled with hv.notebook_extension() above that make it integrate
well with Jupyter/IPython Notebook <http://ipython.org/notebook>_ 2
and 3.

@jlstevens jlstevens force-pushed the fix_broken_links branch from 271571c to cd2ceb9 Apr 12, 2017

@jlstevens

This comment has been minimized.

Copy link
Contributor Author

jlstevens commented Apr 12, 2017

I rebased to get doc building working again. Making the suggested change now and then rebuilding the website.

@jlstevens

This comment has been minimized.

Copy link
Contributor Author

jlstevens commented Apr 12, 2017

Tests are now green and build.holoviews.org has been rebuilt and all the links checked. I think this is ready to merge now.

@philippjfr

This comment has been minimized.

Copy link
Contributor

philippjfr commented Apr 12, 2017

Looks good.

@philippjfr philippjfr merged commit 6874fc1 into master Apr 12, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 79.03%
Details
s3-reference-data-cache Tests passing no test data changes required.
Details

@philippjfr philippjfr deleted the fix_broken_links branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.