Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed comm creation and stream subscriber attachment #1274

Merged
merged 1 commit into from Apr 11, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Apr 11, 2017

Previously the top_level plot attached itself as a subscriber to all the streams found on the plot. Apart from being inefficient because any change to a stream would trigger replotting of the whole Layout, this could cause issues with one plot triggering range updates on another even though the second plot hadn't changed at all.

In this PR each subplot is given access to the comm which means each subplot can be responsible for updating themselves.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Apr 11, 2017

That description makes sense as does the solution. There isn't too much changed code either.

That said, I think the only way we can be sure that everything is working properly is by merging ASAP and building lots of stream examples.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Apr 11, 2017

Test have passed. Want to add some unit tests (might be tricky) or should I just merge?

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Apr 11, 2017

There are some unit tests, which actually caught a bug in my initial attempts at this. So yes, I think it's ready to merge.

@jlstevens jlstevens merged commit 0628872 into master Apr 11, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 79.029%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the stream_comm_attach branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.