Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NdMapping slice lower bound always be inclusive #1686

Merged
merged 1 commit into from Jul 6, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Jul 6, 2017

Fixes a longstanding bug when slicing NdMapping types. When slicing an NdMapping without an upper bound on the slice the lower bound was exclusive for some reason, which is inconsistent with our documentation and what happens when upper bound is supplied.

@philippjfr philippjfr added the bug label Jul 6, 2017

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Jul 6, 2017

If the tests pass, I am happy to merge. This fix definitely deserves an entry in the release notes/changelog!

@philippjfr philippjfr added this to the v1.8.1 milestone Jul 6, 2017

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Jul 6, 2017

Tests are green. Merging.

@jlstevens jlstevens merged commit 0770184 into master Jul 6, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 79.915%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the lower_inclusivity_bug branch Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.