Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodic utility now stops when StopIteration is raised #1792

Merged
merged 1 commit into from Aug 8, 2017

Conversation

Projects
None yet
2 participants
@jlstevens
Copy link
Contributor

jlstevens commented Aug 6, 2017

What is hopefully a simple fix to stop the periodic utility automatically when StopIteration is raised e.g when using a generator in a DynamicMap.

I understand why you might want to skip KeyError in get_plot_frame but I don't get why it is blocking all exceptions and simply printing them. For now I am just catching StopIteration specifically and re-raising those exceptions.

@philippjfr Why can't exceptions other than KeyError be left alone and allowed to bubble up?

@jlstevens

This comment has been minimized.

Copy link
Contributor Author

jlstevens commented Aug 7, 2017

The tests pass but that might not tell us much...

@philippjfr

This comment has been minimized.

Copy link
Contributor

philippjfr commented Aug 8, 2017

This seems safe to me, I'd also like to investigate removing that catch-all exception handler, but not in this PR.

@philippjfr philippjfr merged commit 5e58a86 into master Aug 8, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 79.469%
Details
s3-reference-data-cache Test data is cached.
Details

ea42gh added a commit to ea42gh/holoviews that referenced this pull request Aug 12, 2017

@jlstevens jlstevens added this to the 1.8.3 milestone Aug 21, 2017

@jlstevens jlstevens deleted the periodic_stopiteration branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.