Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up top-level namespace #2224

Merged
merged 2 commits into from Nov 5, 2018

Conversation

Projects
None yet
1 participant
@philippjfr
Copy link
Contributor

philippjfr commented Dec 21, 2017

As suggested in #2202 this PR cleans up the top-level namespace, removing the following items:

Element2D, Element3D, Dimensioned, AttrTree, Overlayable, StoreOptions, UniformNdMapping, ViewableElement, Overlayable, CompositeOverlay

@philippjfr philippjfr added the API label Dec 21, 2017

@philippjfr philippjfr force-pushed the cleanup_namespace branch from 7aa1ef3 to b1a9776 Mar 13, 2018

@philippjfr philippjfr force-pushed the cleanup_namespace branch from b1a9776 to c6aa519 Nov 4, 2018

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Nov 4, 2018

Pared this PR back a bit to make it mergeable in the near term, Element, NdMapping and BoundingBox are therefore still exposed.

@philippjfr philippjfr force-pushed the cleanup_namespace branch from c6aa519 to 6caab09 Nov 4, 2018

Philipp Rudiger Philipp Rudiger

@philippjfr philippjfr force-pushed the cleanup_namespace branch from 6caab09 to 41631f7 Nov 5, 2018

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Nov 5, 2018

Here's the full list of items removed from the top level namespace:

{'AttrTree',
 'CompositeOverlay',
 'Dimensioned',
 'Element2D',
 'Element3D',
 'Overlayable',
 'Tabular',
 'UniformNdMapping',
 'ViewableElement',
 'absolute_import',
 'code',
 'elements_list',
 'f',
 'filename',
 'os',
 'print_function',
 'pydoc',
 'rcfile',
 'warnings'}

@philippjfr philippjfr added this to the v1.11.0 milestone Nov 5, 2018

Philipp Rudiger Philipp Rudiger

@philippjfr philippjfr force-pushed the cleanup_namespace branch from 9377e91 to e55aa47 Nov 5, 2018

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Nov 5, 2018

Going to merge this, @jlstevens gave assent in the linked issue and I have undone the removal of Element that was mentioned as potentially problematic there.

@philippjfr philippjfr merged commit 2311c15 into master Nov 5, 2018

3 of 4 checks passed

s3-reference-data-cache Test data not cached, see details to rebuild.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0003%) to 89.081%
Details

@philippjfr philippjfr deleted the cleanup_namespace branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.