Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetime improvements #2267

Merged
merged 4 commits into from Jan 26, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Jan 23, 2018

This PR has several related purposes:

  • datetime.datetime handled better throughout
  • datetime.date handled (addressing #2100)
  • Use client-side formatters on bokeh tables to allow data to be shared between plots
@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Jan 23, 2018

Looks good.

This reminds me of an issue I wanted to report where the validation for regular sampling didn't seem to work for datetimes after resampling an irregular array onto a regular basis with xarray. That sounds like a fix that might go into a PR though I'll have to come up with a simple reproducible example of the issue unless you already have an idea what I am talking about...

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Jan 23, 2018

This reminds me of an issue I wanted to report where the validation for regular sampling didn't seem to work for datetimes after resampling an irregular array onto a regular basis with xarray.

Please open a separate issue for that.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Jan 26, 2018

Looks good. Merging.

@jlstevens jlstevens merged commit 5686696 into master Jan 26, 2018

3 of 4 checks passed

s3-reference-data-cache Test data not cached, see details to rebuild.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.0%) to 81.242%
Details

philippjfr added a commit that referenced this pull request Feb 9, 2018

@philippjfr philippjfr added this to the 1.9.3 milestone Feb 11, 2018

@philippjfr philippjfr deleted the datetime_improvements branch Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.