Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for datetime streaming bug in bokeh #2383

Merged
merged 2 commits into from Mar 12, 2018

Conversation

Projects
None yet
3 participants
@philippjfr
Copy link
Contributor

philippjfr commented Mar 1, 2018

Very ugly workaround for bokeh/bokeh#7587 in bokeh datetime streaming.

@philippjfr philippjfr force-pushed the datetime_bokeh_bug branch from 4490594 to 3dd2e32 Mar 1, 2018

@stonebig

This comment has been minimized.

Copy link
Contributor

stonebig commented Mar 1, 2018

so my code with bokeh-0.12.5.dev1 will break also ? would it be possible to include it in the test ?

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Mar 1, 2018

so my code with bokeh-0.12.5.dev1 will break also ? would it be possible to include it in the test ?

Probably a good idea.

@philippjfr philippjfr force-pushed the datetime_bokeh_bug branch from 3dd2e32 to ba377db Mar 1, 2018

@philippjfr philippjfr force-pushed the datetime_bokeh_bug branch from ba377db to 86b886c Mar 2, 2018

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Mar 3, 2018

Ready to merge.

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Mar 6, 2018

Looks like this change will require pinning to bokeh>=0.12.14, which also affects 1.9.5 since I ported this change there.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Mar 6, 2018

Looks like this change will require pinning to bokeh>=0.12.14...

Are you going to pin bokeh in this PR? I would also like to see an issue to remove this hack once it is fixed in bokeh to make sure we remove this code when we can.

Otherwise, happy to merge.

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Mar 6, 2018

I would also like to see an issue to remove this hack once it is fixed in bokeh to make sure we remove this code when we can.

Unless we want to remove support for bokeh 0.12.14 we can't really delete this. But I'll pin bokeh now.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Mar 6, 2018

Unless we want to remove support for bokeh 0.12.14 we can't really delete this.

We will be happy to remove support for bokeh 0.12.14 eventually so I would still file an issue. Maybe assign it to the 2.0 milestone.

Philipp Rudiger Philipp Rudiger
@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Mar 12, 2018

Looks good. Merging.

@jlstevens jlstevens merged commit d983551 into master Mar 12, 2018

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.6%) to 82.782%
Details
s3-reference-data-cache Tests passing no test data changes required.
Details

@philippjfr philippjfr deleted the datetime_bokeh_bug branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.