Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic ScrubberWidget and add throttling #2748

Merged
merged 2 commits into from May 29, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented May 29, 2018

Fixes two issues with the ScrubberWidget:

  1. A few releases ago we added the ability to use the ScrubberWidget on a DynamicMap as long all its dimensions define values, however for this to work the plots had to expand the values into their cross-product. We subsequently reverted the expansion change because it was very slow and expensive for large cross products but did not disable the scrubber. This PR ensures that this works even without expanding the whole cross-product.

  2. This PR adds throttling to the ScrubberWidget by using the same approach used by the selection widgets.

@philippjfr philippjfr added the bug label May 29, 2018

@philippjfr philippjfr force-pushed the scrubber_throttling branch from 98cc504 to dd6bd2e May 29, 2018

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented May 29, 2018

Ready for review and merge.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented May 29, 2018

Looks good and I'm glad the most tricky it is contained within a well-defined utility. I'll merge once the pr build goes green too.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented May 29, 2018

The failing pr test was a transient (now restarted). Merging.

@jlstevens jlstevens merged commit bea39dc into master May 29, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 82.816%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the scrubber_throttling branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.