Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug datashading NdOverlay with datetime axis #2829

Merged
merged 1 commit into from Jun 26, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Jun 26, 2018

The datashading code was not converting coordinates back to datetimes when applied to an NdOverlay. This PR simply ensures the same conversion is applied as in all other cases.

  • Fixes #2819
  • Adds unit test

@philippjfr philippjfr force-pushed the datashader_ndoverlay_datetimes branch from 37d94b4 to 46316b4 Jun 26, 2018

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Jun 26, 2018

Looks good. Merging.

@jlstevens jlstevens merged commit bad6210 into master Jun 26, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.9%) to 83.83%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the datashader_ndoverlay_datetimes branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.