Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non-referenced data in dictionary format #2859

Merged
merged 1 commit into from Jul 6, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Jul 6, 2018

Turns out I hadn't correctly caught everything in #2855. This PR further ensures nothing attempts to use dictionary keys that have not been referenced as a dimension.

@philippjfr philippjfr added the data label Jul 6, 2018

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Jul 6, 2018

Happy to merge when the tests pass, though maybe it is worth adding a unit test to ensure the correct behavior?

@philippjfr philippjfr force-pushed the dict_non_dimensions branch from 50340f0 to 170e6b6 Jul 6, 2018

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Jul 6, 2018

Alright added a unit test.

@philippjfr philippjfr force-pushed the dict_non_dimensions branch from 170e6b6 to b6fab7d Jul 6, 2018

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Jul 6, 2018

Tests have just gone green. Merging.

@jlstevens jlstevens merged commit 4227c0f into master Jul 6, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 83.081%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the dict_non_dimensions branch Aug 5, 2018

@philippjfr philippjfr added this to the v1.10.8 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.