Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address loop bug in CDSStream on bokeh server #2915

Merged
merged 1 commit into from Aug 4, 2018

Conversation

Projects
None yet
1 participant
@philippjfr
Copy link
Contributor

philippjfr commented Aug 1, 2018

Fixes an issue when using a CDSStream, or any of the drawing tool streams which are subclasses, on bokeh server. Previously the data dictionary was modified in place which meant it would continuously trigger new events causing an endless loop, by making a copy of the dict we avoid triggering events.

Since we still don't have a way of testing bokeh server apps this can be merged without tests for now.

@philippjfr philippjfr force-pushed the fix_cds_stream_loops branch from b6c2655 to df93fe8 Aug 4, 2018

@philippjfr philippjfr merged commit 1c2040c into master Aug 4, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.9%) to 83.801%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the fix_cds_stream_loops branch Aug 5, 2018

@philippjfr philippjfr added this to the v1.10.8 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.