Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new drawing tool functionality #2937

Merged
merged 4 commits into from Aug 13, 2018

Conversation

Projects
None yet
3 participants
@philippjfr
Copy link
Contributor

philippjfr commented Aug 10, 2018

This PR adds multiple drawing tool features I recently added to bokeh:

  • Adds num_objects option to limit the number of glyphs that can be drawn

  • Adds show_vertices option on PolyDraw enabling display of and snapping to vertices

  • Adds new FreehandDraw stream

  • Tests will have to wait until we have support for Selenium

  • Add documentation
Philipp Rudiger Philipp Rudiger

@philippjfr philippjfr added the feature label Aug 10, 2018

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Aug 11, 2018

There aren't really any tests I can add here without selenium. I'd very much like to set that up soon but I think we should switch to pytest first, since that will allow us to reuse a lot of bokeh's tooling.

So this is ready to review now.

Philipp Rudiger Philipp Rudiger

@philippjfr philippjfr requested a review from jlstevens Aug 13, 2018

"Alternatively we can use the ``element`` property to get an Element containing the returned data:"
]
},
{

This comment has been minimized.

@jlstevens

jlstevens Aug 13, 2018

Contributor

Please clear out the notebook metadata...

Philipp Rudiger Philipp Rudiger
@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Aug 13, 2018

Now the metadata is cleared from the new notebook, I'm happy to merge. No need to wait on tests as the last commit passed and the removal of the notebook metadata is the only change.

@jlstevens jlstevens merged commit a9a2fed into master Aug 13, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@philippjfr philippjfr added this to the v1.11.0 milestone Nov 5, 2018

@philippjfr philippjfr deleted the draw_tool_enhancements branch Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.