Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug streaming SpreadPlot data #2951

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Aug 20, 2018

  • Fixes #2917
  • Adds unit test
Philipp Rudiger Philipp Rudiger
@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Aug 20, 2018

Ready to merge.

@@ -483,6 +483,8 @@ class SpreadPlot(ElementPlot):
style_opts = line_properties + fill_properties
_plot_methods = dict(single='patch')

_stream_data = False # Plot does not support streaming data

This comment has been minimized.

@jlstevens

jlstevens Aug 20, 2018

Contributor

This was very confusing until I realized this might refer to the bokeh use of the word 'streaming'.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Aug 20, 2018

Looks good. The comment would be clearer if it said '# Plot does not support continuous bokeh streaming' (or similar) but that is a very minor complaint. Merging.

@jlstevens jlstevens merged commit 945fc91 into master Aug 20, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 82.877%
Details
s3-reference-data-cache Test data is cached.
Details

philippjfr added a commit that referenced this pull request Oct 25, 2018

@philippjfr philippjfr added this to the v1.10.8 milestone Oct 25, 2018

@philippjfr philippjfr deleted the spread_stream_bug branch Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.