Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address categorical labels not responding to fontsizes #3047

Merged
merged 10 commits into from Oct 8, 2018

Conversation

Projects
None yet
3 participants
@ahuang11
Copy link
Collaborator

ahuang11 commented Oct 5, 2018

#3007

Okay I think it's ready?
image

image

@@ -389,7 +395,12 @@ def _axis_properties(self, axis, key, plot, dimension=None,
Returns a dictionary of axis properties depending
on the specified axis.
"""
axis_props = {}
try:
axis_props = (built_in_themes[self.renderer.theme]

This comment has been minimized.

@philippjfr

philippjfr Oct 5, 2018

Contributor

If we'll be doing this a lot maybe we should have a utility to get the default properties for a particular model type.

@philippjfr philippjfr force-pushed the subcategorical_labels branch 2 times, most recently from e84d17c to 836d4ad Oct 7, 2018

@ahuang11

This comment has been minimized.

Copy link
Collaborator Author

ahuang11 commented Oct 7, 2018

Should I differentiate between major and group? If so, how should I approach it in the inputtable fontsize dictionary; major and minor ticks?

@philippjfr

This comment has been minimized.

Copy link
Contributor

philippjfr commented Oct 7, 2018

If so, how should I approach it in the inputtable fontsize dictionary; major and minor ticks?

That makes sense to me.

@philippjfr

This comment has been minimized.

Copy link
Contributor

philippjfr commented Oct 8, 2018

Looks good to me, ready to merge?

@philippjfr

This comment has been minimized.

Copy link
Contributor

philippjfr commented Oct 8, 2018

Sorry for changing my mind here but could you change this to a try/except after all?

if bokeh_version <= '0.13.0':
    built_in_themes = {}
else:
    from bokeh.themes import built_in_themes

@philippjfr philippjfr force-pushed the subcategorical_labels branch from 775a558 to 0266201 Oct 8, 2018

@ahuang11

This comment has been minimized.

Copy link
Collaborator Author

ahuang11 commented Oct 8, 2018

Looks good to me.

@philippjfr

This comment has been minimized.

Copy link
Contributor

philippjfr commented Oct 8, 2018

Okay, let's merge once tests are passing.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Oct 8, 2018

One build had a transient and needed to be restarted but all the other builds are now green. I'll go ahead and merge.

@jlstevens jlstevens merged commit 8d54a15 into master Oct 8, 2018

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 88.896%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr added this to the v1.10.8 milestone Oct 25, 2018

@philippjfr philippjfr deleted the subcategorical_labels branch Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.