Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop gridplot width kwarg #3051

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Oct 5, 2018

For some reason we were passing a total width to the bokeh gridplot function, which it simply ignored internally. In bokeh 1.0dev this hole in kwarg validation was fixed and passing in the width now errors, so this PR is required for forward compatibility.

Philipp Rudiger Philipp Rudiger
@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Oct 5, 2018

Looks good. Merging.

@jlstevens jlstevens merged commit 299ee5b into master Oct 5, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 83.122%
Details
s3-reference-data-cache Test data is cached.
Details

philippjfr added a commit that referenced this pull request Oct 25, 2018

@philippjfr philippjfr deleted the gridplot_fix branch Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.