Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure toolbar=None does not disable tools #3074

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Oct 10, 2018

As discussed in #3006 setting toolbar=None should not disable all the tools, it should simply hide the toolbar. I've added a toolbar='disable' option instead.

@philippjfr philippjfr added the bokeh label Oct 10, 2018

@philippjfr philippjfr force-pushed the disable_toolbar branch from b9909bc to 4d030a2 Oct 10, 2018

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Oct 10, 2018

Looks good! Merging.

@jlstevens jlstevens merged commit 643cd7e into master Oct 10, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 88.901%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr added this to the v1.10.8 milestone Oct 25, 2018

@philippjfr philippjfr deleted the disable_toolbar branch Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.