Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle updating of bokeh legends #3139

Merged
merged 9 commits into from Nov 5, 2018

Conversation

Projects
None yet
1 participant
@philippjfr
Copy link
Contributor

philippjfr commented Nov 5, 2018

Previous legends were completely static in the bokeh backend, i.e. in a HoloMap it would display all legend items for all frames at once and in a DynamicMap they would simply not update. Additionally this PR fixes a bug where the addition of an annotation on a plot would cause a legend to appear.

Also includes various fixes for dynamically creating and reassigning plot instances to ensure that a) the cyclic index is consistent and that b) dynamically created plot instances are updated appropriately despite not being assigned the correct stream mappings.

@philippjfr philippjfr added this to the v1.11.0 milestone Nov 5, 2018

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Nov 5, 2018

Going ahead and merging this, it's all changes in the plotting code which are hard to review anyway and I also want to ensure that this is tested for as long as possible before a release.

@philippjfr philippjfr merged commit 97f6d9a into master Nov 5, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 88.765%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the dynamic_legend branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.