Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas 0.24 compatibility and CI fixes #3433

Merged
merged 51 commits into from Jan 27, 2019

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Jan 26, 2019

The pandas dtype extensions changed slightly in 0.24 breaking HoloViews in major ways in the process. Apart from updating the import, to avoid this in future I've split the try/except blocks to separate the extension types and added a warning.

@jbednar

This comment has been minimized.

Copy link
Contributor

jbednar commented Jan 26, 2019

Thanks. Are there any compatibility patches you could propose for Pandas itself, to avoid such problems with other libraries?

philippjfr added some commits Jan 26, 2019

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Jan 26, 2019

Are there any compatibility patches you could propose for Pandas itself, to avoid such problems with other libraries?

No, this is entirely on us (or rather me).

philippjfr added some commits Jan 26, 2019

philippjfr added some commits Jan 27, 2019

@philippjfr philippjfr force-pushed the pandas_0.24_compat branch from 1075e76 to d953198 Jan 27, 2019

philippjfr added some commits Jan 27, 2019

@philippjfr philippjfr force-pushed the pandas_0.24_compat branch 4 times, most recently from a79cc3a to 68f523d Jan 27, 2019

@philippjfr philippjfr force-pushed the pandas_0.24_compat branch from 68f523d to eff9615 Jan 27, 2019

@philippjfr philippjfr force-pushed the pandas_0.24_compat branch from 532ac5a to 2c23d88 Jan 27, 2019

philippjfr added some commits Jan 27, 2019

@philippjfr philippjfr changed the title Pandas 0.24 compatibility Pandas 0.24 compatibility and CI fixes Jan 27, 2019

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Jan 27, 2019

I'm going to merge this shortly. Basically there are two remaining issues:

  • Gif and mp4 renderer tests are basically skipped in linux right now, I tried fixing this even going so far as trying to reproduce it in a linux virtual machine but had no luck.
  • Appveyor builds are currently broken (across all our projects), I've allowed them to go green despite this failure for now and filed an issue here: appveyor/ci#2822

The PR does the following:

  • Update to all latest versions (including pandas 0.24.0, matplotlib, xarray etc.)
  • Compatibility for pandas 0.24.0
  • Add appveyor.yml (which was briefly passing until the miniconda on appveyor was updated and broken)

@philippjfr philippjfr merged commit 9b23328 into master Jan 27, 2019

5 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0005%) to 89.839%
Details
s3-reference-data-cache Test data is cached.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.