Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that bokeh plot refresh has the Document lock #3621

Merged
merged 2 commits into from Apr 26, 2019

Conversation

Projects
None yet
1 participant
@philippjfr
Copy link
Contributor

commented Apr 12, 2019

Currently it is possible to get into situation where HoloViews plot classes modify the models without having the Document lock, leading to errors like this:

holoviews.core.options.AbbreviatedException: RuntimeError: _pending_writes should be non-None when we have a document lock, and we should have the lock when the document changes

@philippjfr philippjfr force-pushed the fix_pending_writes branch 2 times, most recently from fb74f61 to a666707 Apr 26, 2019

@philippjfr philippjfr force-pushed the fix_pending_writes branch from a666707 to 7405b4d Apr 26, 2019

@philippjfr philippjfr added this to the v1.12.2 milestone Apr 26, 2019

@philippjfr philippjfr merged commit a1213a5 into master Apr 26, 2019

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 87.69%
Details

@philippjfr philippjfr deleted the fix_pending_writes branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.