Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotly 3.8 support #3644

Merged
merged 2 commits into from Apr 22, 2019

Conversation

Projects
None yet
3 participants
@jonmmease
Copy link
Collaborator

commented Apr 22, 2019

Closes #3643

Two changes:

  • Change plotly.offline.offline.utils to plotly.utils
  • Only add legend options to traces that support them. Plotly.js cleaned up the schema a bit to remove these entries from traces that don't use them, which resulted in some validation errors here.

These changes are backward compatible with plotly.py <3.8 so no need to change version constraints.

@jbednar

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

Thanks!

@philippjfr philippjfr added this to the v1.12.2 milestone Apr 22, 2019

@philippjfr

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

Looks great, thanks!

@philippjfr philippjfr merged commit 325d03d into master Apr 22, 2019

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 87.703%
Details

@philippjfr philippjfr deleted the bug_3643 branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.