Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numpy logs to transformations #3731

Merged
merged 8 commits into from May 25, 2019

Conversation

@henriqueribeiro
Copy link
Contributor

commented May 24, 2019

As title states, this PR adds logs function to the available transformations

@philippjfr

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

One of the existing tests will need to be updated, otherwise this looks fine to me:

  File "/home/travis/build/pyviz/holoviews/holoviews/tests/util/testtransform.py", line 173, in test_ufunc_expression_repr
    self.assertEqual(repr(np.log(dim('float'))), "np.log(dim('float'))")
  File "/home/travis/build/pyviz/holoviews/holoviews/element/comparison.py", line 79, in assertEqual
    asserter(first, second)
  File "/home/travis/build/pyviz/holoviews/holoviews/element/comparison.py", line 56, in simple_equality
    raise cls.failureException(msg or standardMsg)
AssertionError: "dim('float').log()" != "np.log(dim('float'))"
@philippjfr

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

Thanks a lot for contributing!

@henriqueribeiro

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

Just fixed the test @philippjfr

@philippjfr philippjfr merged commit 145b6a1 into pyviz:master May 25, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 87.745%
Details
@jlstevens

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Thanks for the PR @henriqueribeiro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.