Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datetime handling for spikes #3736

Merged
merged 2 commits into from May 27, 2019

Conversation

@poplarShift
Copy link
Collaborator

commented May 27, 2019

The previous implementation of get_data for Spikes in the matplotlib backend used the element.array() method, which already coerces datetime values to int in case of mixed data types. I fixed that and updated the datetime handling using recently added utils.

The following now works, whereas before it didn't:

import pandas as pd
import numpy as np
import holoviews as hv
hv.extension('matplotlib')

e = hv.Spikes((pd.date_range('2100-1-1', '2100-10-10', periods=20), np.random.rand(20)), 'Date', 'c')
e.opts(xrotation=45)

Screen Shot 2019-05-27 at 3 20 57 PM

@philippjfr

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

Thanks @poplarShift!

@philippjfr philippjfr merged commit ed8a329 into master May 27, 2019

3 of 4 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on spikes_datetime at 87.768%
Details
@jlstevens

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Yes, thank you @poplarShift!

@poplarShift poplarShift deleted the spikes_datetime branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.