Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow automatic extent scaling on line annotations #3761

Merged
merged 3 commits into from Jun 21, 2019

Conversation

@poplarShift
Copy link
Collaborator

commented Jun 6, 2019

Fixes #3759

The following is now possible:

import holoviews as hv
hv.extension('bokeh')
import numpy as np

hv.VLine(-1).opts(apply_ranges=True, padding=.1) * hv.Scatter(np.random.rand(100,2))

Note that in the matplotlib backend ranges were apparently already applied before then.

@@ -130,6 +130,8 @@ class LineAnnotationPlot(ElementPlot, AnnotationPlot):

style_opts = line_properties + ['level']

apply_ranges = False

This comment has been minimized.

Copy link
@philippjfr

philippjfr Jun 21, 2019

Contributor

I think this should probably be a boolean parameter.

This comment has been minimized.

Copy link
@poplarShift

poplarShift Jun 21, 2019

Author Collaborator

Ah, of course.

@poplarShift poplarShift requested a review from philippjfr Jun 21, 2019

@philippjfr philippjfr merged commit fd57be8 into master Jun 21, 2019

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 87.941%
Details

@philippjfr philippjfr deleted the line_annot_extent branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.