Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPL 3.1 deprecations to rcparam context manager #3804

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@poplarShift
Copy link
Collaborator

commented Jul 5, 2019

Completes #3745 and thereby fixes #3766
Source: https://matplotlib.org/3.1.0/api/api_changes.html

This confused me for a bit, but it turned out that the deprecated arguments were simply carried over from matplotlib.rcParams where they then threw the warnings.

@poplarShift poplarShift added the mpl label Jul 5, 2019

@philippjfr

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

Sorry you had to go through discovering this, I remember being confused by this for a very long time.

@poplarShift

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 5, 2019

@philippjfr philippjfr force-pushed the rcparam_deprecations branch from f4a69c9 to 758857e Jul 9, 2019

@philippjfr philippjfr merged commit 23ead43 into master Jul 9, 2019

2 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on rcparam_deprecations at 87.754%
Details
@poplarShift

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 9, 2019

Didn't know you were ready to merge yet. I recall some unit tests were failing on grounds of plot sizes or something, is that resolved? Hadn't had time to look into that yet.

@philippjfr

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Didn't know you were ready to merge yet. I recall some unit tests were failing on grounds of plot sizes or something, is that resolved? Hadn't had time to look into that yet.

Yes, sorry, should have warned. I fixed that separately.

@poplarShift

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 9, 2019

Perfect, no problem!

@philippjfr philippjfr deleted the rcparam_deprecations branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.