Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of data_aspect #3848

Merged
merged 3 commits into from Jul 25, 2019

Conversation

@philippjfr
Copy link
Contributor

commented Jul 24, 2019

This PR allows setting the data_aspect even if a fixed width and height are set by adjusting the plot ranges instead of the width and height of the plot. This is already what data_aspect did after the initialization of a plot so all this changes is that this can now also be done during plot initialization.

This is an important usecase and an unfortunate oversight. I also think there was an issue with inverted handling for data_aspect in certain scenarios.

@philippjfr philippjfr added the bug label Jul 24, 2019

@philippjfr philippjfr merged commit 9c5b90b into master Jul 25, 2019

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 87.794%
Details

@philippjfr philippjfr deleted the philippjfr/data_aspect_fix branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.