Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured initial dynamicmap values are escaped correctly in widgets #478

Merged
merged 1 commit into from Feb 9, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Feb 9, 2016

The widgets require slightly different escaping when using DynamicMap, this PR ensures they are escaped correctly to avoid a bug where all sliders would have to be moved from their default position for DynamicMap to work.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Feb 9, 2016

Doesn't look too bad. I'm happy to merge as soon as the tests pass.

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Feb 9, 2016

Ready to merge.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Feb 9, 2016

Ok. Merging now.

jlstevens added a commit that referenced this pull request Feb 9, 2016

Merge pull request #478 from ioam/dynamic_fix
Ensured initial dynamicmap values are escaped correctly in widgets

@jlstevens jlstevens merged commit adb56eb into master Feb 9, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 69.493%
Details
s3-reference-data-cache Test data is cached.
Details

@jlstevens jlstevens deleted the dynamic_fix branch Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.