Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating dimension ranges in dynamic sampled mode #483

Merged
merged 2 commits into from Feb 9, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Feb 9, 2016

As the title says this makes sure that when plotting a DynamicMap in sampled mode, i.e. next to a HoloMap that provides the sampling, that all the keys are actually within the ranges specified on the DynamicMap dimensions.

Philipp Rudiger added some commits Feb 9, 2016

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Feb 9, 2016

Tests are passing and I believe it is ready to merge.

jlstevens added a commit that referenced this pull request Feb 9, 2016

Merge pull request #483 from ioam/dynamic_fixes
Validating dimension ranges in dynamic sampled mode

@jlstevens jlstevens merged commit 85d6ae4 into master Feb 9, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 69.458%
Details
s3-reference-data-cache Test data is cached.
Details

@jlstevens jlstevens deleted the dynamic_fixes branch Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.