Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Columns Element to Dataset #620

Merged
merged 7 commits into from Apr 20, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Apr 19, 2016

As the title says this is a simple renaming from Columns to Dataset. This is because data interfaces are no longer required to be columnar, also supporting gridded data for instance. A general baseclass called Dataset will be very useful to wrap very high-dimensional datasets, which do not have a clear visual representation.

Philipp Rudiger Philipp Rudiger

@philippjfr philippjfr added the API label Apr 19, 2016

@philippjfr philippjfr added this to the v1.5.0 milestone Apr 19, 2016

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Apr 19, 2016

Ready to merge, preferably via the new squash commit functionality.

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Apr 19, 2016

Need to look into why the data cache is complaining, even though the tests are passing, at some point.

@philippjfr philippjfr referenced this pull request Apr 19, 2016

Merged

Conversion refactor #622

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Apr 20, 2016

Need to look into why the data cache is complaining, even though the tests are passing, at some point.

Ok, sounds liked you can do that in a different PR. Merging.

@jlstevens jlstevens merged commit 1f186cd into master Apr 20, 2016

3 of 4 checks passed

s3-reference-data-cache Test data not cached, see details to rebuild.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on dataset_rename at 69.527%
Details

@philippjfr philippjfr removed the in progress label Apr 20, 2016

@philippjfr philippjfr deleted the dataset_rename branch Apr 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.