Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay collate #952

Merged
merged 3 commits into from Oct 28, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Oct 25, 2016

This PR addresses issue #530, which suggested that creating an Overlay of HoloMaps to make it easy to declare certain datastructures. This PR reimplements the Layout.from_values method to be more efficient by not creating a bunch of intermediate objects, which also makes it possible to create an Overlay of HoloMaps and GridSpaces. Additionally it adds a trivial collate implementation which simply mirrors the old from_values implementation by reducing all the objects with the __mul__ operator. Finally it sets up Overlays of HoloMaps and GridSpaces to be automatically collated and issue a warning like we already do for other invalid nesting structures.

@philippjfr philippjfr force-pushed the overlay_collate branch from 416c1fa to f5c9e2f Oct 25, 2016

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Oct 28, 2016

Having things work but issue a warning is something we already partially implemented. This PR completes that - or at least, I can't currently think of any other similar collation+warning scenario.

The increased efficiency is also nice! Merging.

@jlstevens jlstevens merged commit 8449ef0 into master Oct 28, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 75.752%
Details
s3-reference-data-cache Tests passing no test data changes required.
Details

@philippjfr philippjfr deleted the overlay_collate branch Jan 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.