From e1bdd409613d756dc5e6ec9dce1fcb7bd6f22248 Mon Sep 17 00:00:00 2001 From: Andreas Maier Date: Thu, 30 Jul 2020 08:42:11 +0200 Subject: [PATCH] Pinned prompt-toolkit to <3.0 on Python 3.8 on Windows to avoid WinError 995. Details: * Pinned prompt-toolkit to <3.0 on Python 3.8 on Windows to avoid WinError 995. (See issue #690) * In requirements.txt, clarified the reasons for the other version constraints on prompt-toolkit. Signed-off-by: Andreas Maier --- docs/changes.rst | 3 +++ requirements.txt | 13 +++++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/docs/changes.rst b/docs/changes.rst index 37cf6cc8..a753409d 100644 --- a/docs/changes.rst +++ b/docs/changes.rst @@ -29,6 +29,9 @@ Released: not yet name so the same order of instance names is displayed for all versions of Python. (See issue #458 and #459) +* Pinned prompt-toolkit to <3.0 on Python 3.8 on Windows to avoid WinError 995. + (See issue #690) + **Enhancements:** * Modify general help to display the full path of the default connections file. diff --git a/requirements.txt b/requirements.txt index 930e41b4..ee4ba437 100644 --- a/requirements.txt +++ b/requirements.txt @@ -19,13 +19,22 @@ click-spinner>=0.1.8 click-repl>=0.1.6 asciitree>=0.3.3 tabulate>=0.8.2 -prompt-toolkit>=2.0.1; python_version >= '3.4' -# See pywbemtools issue # 192. The repl mode fails with unexpected Exception + +# prompt-toolkit>=2.0 failed on py27 (issue #192), so it was pinned to <2.0. +# Later, the fix for issue #224 allowed to lift that pinning. +# prompt-toolkit>=3.0 does not support py27. +# prompt-toolkit>=3.0 may cause WinError 995 on py38 on Windows (issue #690). prompt-toolkit>=1.0.15,<3.0.0; python_version == '2.7' +prompt-toolkit>=2.0.1; python_version >= '3.4' and python_version < '3.8' +prompt-toolkit>=2.0.1; python_version >= '3.8' and sys_platform != 'win32' +prompt-toolkit>=2.0.1,<3.0.0; python_version >= '3.8' and sys_platform == 'win32' + pydicti>=1.1.3 + # PyYAML 5.3 has removed support for Python 3.4 PyYAML>=5.1; python_version == '2.7' PyYAML>=5.1,<5.3; python_version == '3.4' PyYAML>=5.1; python_version > '3.4' + yamlloader>=0.5.5 packaging>=17.0